Re: [RFT PATCH 2/4] usb: dwc2: Turn on uframe_sched on "his" platforms

From: John Stultz
Date: Tue Jul 10 2018 - 19:34:17 EST


On Fri, Jul 6, 2018 at 9:21 AM, Douglas Anderson <dianders@xxxxxxxxxxxx> wrote:
> There's no reason to have the uframe scheduler off on dwc2. Running
> with uframe_sched = False is equivalent to saying "I don't want to run
> the correct code, I want to run the old and incorrect code".
>
> The uframe scheduler has been off on HiSilicon since commit
> 37dd9d65cc41 ("usb: dwc2: add support of hi6220"). Since then there
> have been many many improvements, notably the commit 9f9f09b048f5
> ("usb: dwc2: host: Totally redo the microframe scheduler")
>
> Presumably if everyone is good w/ the uframe_sched turned back on we
> can kill all the old and crufty non-uframe sched code.
>
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

Not sure exactly how to exercise this, but in my initial testing with
usb on HiKey, this seems to work ok.

Tested-by: John Stultz <john.stultz@xxxxxxxxxx>

thanks
-john