Re: [PATCH] checkpatch: Require author Signed-off-by

From: Geert Uytterhoeven
Date: Tue Jul 10 2018 - 11:07:45 EST


Hi Joe,

On Tue, Jul 10, 2018 at 4:34 PM Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Tue, 2018-07-10 at 14:10 +0200, Geert Uytterhoeven wrote:
> > Print an error if none of the Signed-off-by lines cover the patch
> > author.
> []
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -13,6 +13,7 @@ use POSIX;
> > use File::Basename;
> > use Cwd 'abs_path';
> > use Term::ANSIColor qw(:constants);
> > +use MIME::Words 'decode_mimewords';
>
> Is this a typically installed perl module?
> If so, what perl version installed it by default?

I don't know. At least my Ubuntu 16.04LTS and 18.04LTS systems had it
installed.
It does not seem to be part of the core modules, cfr.
https://perldoc.perl.org/index-modules-M.html

I've tried using MIME::QuotedPrint instead, but then we need to parse
=?UTF-8?q? ourselves, as decode_qp() only transforms the actual
quoted printable bits in side the encoded From: address.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds