Re: linux-next: build warning after merge of the scsi tree

From: Jens Axboe
Date: Tue Jul 10 2018 - 10:10:06 EST


On 7/10/18 1:31 AM, Stephen Rothwell wrote:
> Hi all,
>
> On Wed, 20 Jun 2018 13:29:10 +1000 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>>
>> After merging the scsi tree, today's linux-next build (powerpc
>> allyesconfig) produced this warning:
>>
>> In file included from include/target/target_core_base.h:7:0,
>> from drivers/target/target_core_tmr.c:31:
>> include/linux/sbitmap.h:331:46: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>> void sbitmap_show(struct sbitmap *sb, struct seq_file *m);
>> ^~~~~~~~
>> include/linux/sbitmap.h:342:53: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>> void sbitmap_bitmap_show(struct sbitmap *sb, struct seq_file *m);
>> ^~~~~~~~
>> include/linux/sbitmap.h:530:59: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>> void sbitmap_queue_show(struct sbitmap_queue *sbq, struct seq_file *m);
>> ^~~~~~~~
>> In file included from include/target/target_core_base.h:7:0,
>> from drivers/target/target_core_ua.c:30:
>> include/linux/sbitmap.h:331:46: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>> void sbitmap_show(struct sbitmap *sb, struct seq_file *m);
>> ^~~~~~~~
>> include/linux/sbitmap.h:342:53: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>> void sbitmap_bitmap_show(struct sbitmap *sb, struct seq_file *m);
>> ^~~~~~~~
>> include/linux/sbitmap.h:530:59: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>> void sbitmap_queue_show(struct sbitmap_queue *sbq, struct seq_file *m);
>> ^~~~~~~~
>>
>> Introduced by commit
>>
>> 24af1ccfe12a ("sbitmap: add helpers for dumping to a seq_file")
>>
>> in v4.11.rc1, but exposed by commit
>>
>> eca7ee1f33e8 ("scsi: target: Convert target drivers to use sbitmap")
>
> I am still seeing these warnings ...

Martin queued up the forward declaration patch for this one, not sure
why it isn't showing up in the scsi tree yet.

--
Jens Axboe