Re: [PATCH 1/2] mm/cma: remove unsupported gfp_mask parameter from cma_alloc()

From: Joonsoo Kim
Date: Tue Jul 10 2018 - 03:19:39 EST


Hello, Marek.

2018-07-09 21:19 GMT+09:00 Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>:
> cma_alloc() function doesn't really support gfp flags other than
> __GFP_NOWARN, so convert gfp_mask parameter to boolean no_warn parameter.

Although gfp_mask isn't used in cma_alloc() except no_warn, it can be used
in alloc_contig_range(). For example, if passed gfp mask has no __GFP_FS,
compaction(isolation) would work differently. Do you have considered
such a case?

Thanks.