Re: [PATCH 1/8] usb: pd: include kernel.h

From: Guenter Roeck
Date: Mon Jul 09 2018 - 14:58:10 EST


On Wed, Jun 27, 2018 at 06:19:46PM +0300, Heikki Krogerus wrote:
> This makes life a bit easier for the drivers that include
> pd.h. All pd_header_*_le() inline functions defined in pd.h
> call le16_to_cpu(), and all *_LE() macros in pd.h call
> cpu_to_le16().
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> ---
> include/linux/usb/pd.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/usb/pd.h b/include/linux/usb/pd.h
> index 09b570feb297..f2162e0fe531 100644
> --- a/include/linux/usb/pd.h
> +++ b/include/linux/usb/pd.h
> @@ -15,6 +15,7 @@
> #ifndef __LINUX_USB_PD_H
> #define __LINUX_USB_PD_H
>
> +#include <linux/kernel.h>

What is more appropriate ? This or asm/byteorder.h ?

Guenter

> #include <linux/types.h>
> #include <linux/usb/typec.h>
>
> --
> 2.18.0
>