Re: [PATCH] regulator: core: Don't link consumers on the same device

[Mark Brown]

On Mon, Jul 09, 2018 at 03:32:14PM +0200, Marek Szyprowski wrote:

> This patch doesn't help, because wm8994 creates separate struct device for
> each registered regulator, so you need to check the regulator parents too,
> see my fixes below in the patch.

Ugh, right - I'd not looked at enough of the context to see what was
being checked.

> I don't like such fixes for this specific case. It's not that uncommon
> that a complex device provides various functionalities used by its
> components, so it is not a bad design to use regulator provided by
> its parent/grandparent/other ancestor device.

> Frankly, either the device_is_dependent() function should be exported and
> used in regulator core or device_link_add() should have another flag:
> DL_FLAG_SKIP_DEPENDANT.

Or it should just make the warning optional at the core level.

Attachment: signature.asc
Description: PGP signature