Re: [PATCH 1/2] dt-bindings: reset: uniphier: add USB3 controller reset support

From: Philipp Zabel
Date: Fri Jun 29 2018 - 05:57:58 EST


On Fri, 2018-06-29 at 17:11 +0900, Kunihiko Hayashi wrote:
> Add DT bindings for reset control of USB3 controller implemented in
> UniPhier SoCs.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/reset/uniphier-reset.txt | 45 ++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/reset/uniphier-reset.txt b/Documentation/devicetree/bindings/reset/uniphier-reset.txt
> index 93efed6..f21d81c 100644
> --- a/Documentation/devicetree/bindings/reset/uniphier-reset.txt
> +++ b/Documentation/devicetree/bindings/reset/uniphier-reset.txt
> @@ -118,3 +118,48 @@ Example:
>
> other nodes ...
> };
> +
> +
> +USB3 controller reset
> +---------------------
> +
> +Required properties:
> +- compatible: Should be
> + "socionext,uniphier-pro4-usb3-reset" - for Pro4 SoC
> + "socionext,uniphier-pxs2-usb3-reset" - for PXs2 SoC
> + "socionext,uniphier-ld20-usb3-reset" - for LD20 SoC
> + "socionext,uniphier-pxs3-usb3-reset" - for PXs3 SoC
> +- #reset-cells: Should be 1.
> +- reg: Specifies offset and length of the register set for the device.
> +- clocks: A list of phandles to the clock gate for USB3 glue layer.
> + According to the clock-names, appropriate clocks are required.
> +- clock-names: Should contain
> + "gio", "link" - for Pro4 SoC
> + "link" - for others
> +- resets: A list of phandles to the reset control for USB3 glue layer.
> + According to the reset-names, appropriate resets are required.
> +- reset-names: Should contain
> + "gio", "link" - for Pro4 SoC
> + "link" - for others
> +
> +Example:
> +
> + usb-glue@65b00000 {
> + compatible = "socionext,uniphier-ld20-dwc3-glue",
> + "simple-mfd";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0x65b00000 0x400>;
> +
> + usb_rst: reset@0 {
> + compatible = "socionext,uniphier-ld20-usb3-reset";
> + reg = <0x0 0x4>;
> + #reset-cells = <1>;
> + clock-names = "link";
> + clocks = <&sys_clk 14>;
> + clock-names = "link";

s/clock/reset/

> + resets = <&sys_rst 14>;
> + };
> +
> + other nodes ...
> + };

regards
Philipp