Re: [patch 1/2] posix-timers: Make forward callback return s64

From: John Stultz
Date: Fri Jun 29 2018 - 00:27:36 EST


On Tue, Jun 26, 2018 at 6:21 AM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> The posix timer ti_overrun handling is broken because the forwarding
> functions can return a huge number of overruns which does not fit in an
> int. As a consequence timer_getoverrun(2) and siginfo::si_overrun can turn
> into random number generators.
>
> As a first step to address that let the timer_forward() callbacks return
> the full 64 bit value.
>
> Cast it to (int) temporarily until k_itimer::ti_overrun is converted to
> 64bit and the conversion to user space visible values is sanitized.
>
> Reported-by: air icy <icytxw@xxxxxxxxx>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

Looks ok, and doesn't trip any regressions in testing so far.

Acked-by: John Stultz <john.stultz@xxxxxxxxxx>

thanks
-john