Re: [PATCH 2/3] locking: Clarify requirements for smp_mb__after_spinlock()

From: Andrea Parri
Date: Thu Jun 28 2018 - 09:52:21 EST


> > + * smp_mb__after_spinlock() provides a full memory barrier between po-earlier
> > + * lock acquisitions and po-later memory accesses.
>
> How about saying "provides the equivalent of a full memory barrier"?
>
> The point being that smp_mb__after_spinlock doesn't have to provide an
> actual barrier; it just has to ensure the behavior is the same as if a
> full barrier were present.

Agreed; will fix in the next version. Thanks,

Andrea


>
> Alan
>