Re: [PATCH 1/2] ARM: dts: imx51-babbage: Fix reg for usbh1phy

[Fabio Estevam]

Hi Andrey,

On Thu, Jun 28, 2018 at 1:37 AM, Andrey Smirnov
<andrew.smirnov@xxxxxxxxx> wrote:
> There's already a USB PHY with reg of zero on that bus - usbphy0, used
> by usbotg (included from imx51.dtsi). Move usbh1phy to @1 avoid
> address collision.
>
> Cc: Fabio Estevam <fabio.estevam@xxxxxxx>
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
> ---
>  arch/arm/boot/dts/imx51-babbage.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx51-babbage.dts b/arch/arm/boot/dts/imx51-babbage.dts
> index b8ca73d3d379..541c6e67ad1a 100644
> --- a/arch/arm/boot/dts/imx51-babbage.dts
> +++ b/arch/arm/boot/dts/imx51-babbage.dts
> @@ -175,9 +175,9 @@
>                 #size-cells = <0>;
>                 compatible = "simple-bus";
>
> -               usbh1phy: usbh1phy@0 {
> +               usbh1phy: usbh1phy@1 {
>                         compatible = "usb-nop-xceiv";
> -                       reg = <0>;
> +                       reg = <1>;

We don't really need the 'reg' property here.

I have sent a previous fix for this on an attempt to fix dtc warnings
with W=1,  so let me send a v2 based on the feedback I got previously:
https://patchwork.kernel.org/patch/10399085/

Thanks