RE: [[LINUX PATCH v10] 4/4] mtd: rawnand: pl353: Add basic driver for arm pl353 smc nand interface

[Naga Sureshkumar Relli]

Hi Linus,

> -----Original Message-----
> From: Linus Walleij [mailto:linus.walleij@xxxxxxxxxx]
> Sent: Thursday, June 28, 2018 1:14 PM
> To: Naga Sureshkumar Relli <nagasure@xxxxxxxxxx>
> Cc: Boris Brezillon <boris.brezillon@xxxxxxxxxxx>; Richard Weinberger <richard@xxxxxx>;
> David Woodhouse <dwmw2@xxxxxxxxxxxxx>; Brian Norris
> <computersforpeace@xxxxxxxxx>; Mark Vasut <marek.vasut@xxxxxxxxx>; Florian Fainelli
> <f.fainelli@xxxxxxxxx>; Markus Mayer <mmayer@xxxxxxxxxxxx>; Roger Quadros
> <rogerq@xxxxxx>; Ladislav Michl <ladis@xxxxxxxxxxxxxx>; ada@xxxxxxxxxxx;
> honghui.zhang@xxxxxxxxxxxx; MiquÃl Raynal <miquel.raynal@xxxxxxxxxxx>; linux-
> mtd@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; nagasureshkumarrelli@xxxxxxxxx;
> Michal Simek <michals@xxxxxxxxxx>
> Subject: Re: [[LINUX PATCH v10] 4/4] mtd: rawnand: pl353: Add basic driver for arm
> pl353 smc nand interface
> 
> On Thu, Jun 21, 2018 at 8:43 AM Naga Sureshkumar Relli
> <naga.sureshkumar.relli@xxxxxxxxxx> wrote:
> 
> Thank you for your patch!
> 
> > Add driver for arm pl353 static memory controller nand interface with
> > HW ECC support. This controller is used in Xilinx Zynq SoC for
> > interfacing the NAND flash memory.
> >
> > Signed-off-by: Naga Sureshkumar Relli
> > <naga.sureshkumar.relli@xxxxxxxxxx>
> 
> This driver has the same problem as the other patches:
> use the ARM_AMBA primecell magic numbers detection, and the PrimeCell bus.
Here the child is NAND controller and the parent is PL353 SMC, 
so do we need to update this also as AMBA driver?

Thanks,
Naga Sureshkumar Relli


> 
> Otherwise it looks good to me!
> 
> Yours,
> Linus Walleij