Re: [PATCH v3 11/24] drm/sun4i: Don't check for LVDS and RGB when TCON has only ch1

From: Chen-Yu Tsai
Date: Wed Jun 27 2018 - 22:09:22 EST


On Mon, Jun 25, 2018 at 8:02 PM, Jernej Skrabec <jernej.skrabec@xxxxxxxx> wrote:
> LVDS and RGB interfaces are always connected to TCONs which have channel
> 0. It doesn't make sense to try to init them on TV TCONs.
>
> Add a check if TCON has channel 0 before trying to init LVDS or RGB
> interface.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@xxxxxxxx>

Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxx>

Though I think at some point we could just have separate functions
to handle channel 0 and channel 1.

ChenYu