RE: [PATCH] ARM: dts: imx6sll-evk: enable usdhc3 slot

[Anson Huang]

Hi, Fabio

Anson Huang
Best Regards!


> -----Original Message-----
> From: Fabio Estevam [mailto:festevam@xxxxxxxxx]
> Sent: Wednesday, June 27, 2018 10:31 PM
> To: Anson Huang <anson.huang@xxxxxxx>
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>; Sascha Hauer
> <s.hauer@xxxxxxxxxxxxxx>; Sascha Hauer <kernel@xxxxxxxxxxxxxx>; Fabio
> Estevam <fabio.estevam@xxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>;
> Mark Rutland <mark.rutland@xxxxxxx>; open list:OPEN FIRMWARE AND
> FLATTENED DEVICE TREE BINDINGS <devicetree@xxxxxxxxxxxxxxx>;
> dl-linux-imx <linux-imx@xxxxxxx>; moderated list:ARM/FREESCALE IMX / MXC
> ARM ARCHITECTURE <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>; linux-kernel
> <linux-kernel@xxxxxxxxxxxxxxx>
> Subject: Re: [PATCH] ARM: dts: imx6sll-evk: enable usdhc3 slot
> 
> Hi Anson,
> 
> On Wed, Jun 27, 2018 at 5:36 AM, Anson Huang <Anson.Huang@xxxxxxx>
> wrote:
> 
> > +&usdhc3 {
> > +       pinctrl-names = "default", "state_100mhz", "state_200mhz";
> > +       pinctrl-0 = <&pinctrl_usdhc3>;
> > +       pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
> > +       pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
> > +       cd-gpios = <&gpio3 22 GPIO_ACTIVE_LOW>;
> > +       keep-power-in-suspend;
> > +       enable-sdio-wakeup;
> > +       vmmc-supply = <&reg_sd3_vmmc>;
> > +       status = "okay";
> > +};
> > +
> >  &usbotg1 {
> 
> Please keep the nodes sorted in alphabetical order.

Thanks, it is because original code does NOT do it in alphabetical order, so I just added
usdhc3 at the end of usdhc1, but I sent V2 patch to re-sort it anyway, please review it.  

Anson.