Re: [PATCH] bus: ti-sysc: Use 2-factor allocator arguments

[Kees Cook]

On Mon, Jun 18, 2018 at 10:45 AM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> This adjusts the allocator calls to use 2-factor argument call style, as
> done treewide already for improved defense against allocation overflows.
>
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>

Friendly ping! :) This is the last 2-factor devm* allocation left in
4.18 to be fixed.

Thanks!

-Kees

> ---
>  drivers/bus/ti-sysc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> index 1cc29629d238..80d60f43db56 100644
> --- a/drivers/bus/ti-sysc.c
> +++ b/drivers/bus/ti-sysc.c
> @@ -169,9 +169,9 @@ static int sysc_get_clocks(struct sysc *ddata)
>         const char *name;
>         int nr_fck = 0, nr_ick = 0, i, error = 0;
>
> -       ddata->clock_roles = devm_kzalloc(ddata->dev,
> -                                         sizeof(*ddata->clock_roles) *
> +       ddata->clock_roles = devm_kcalloc(ddata->dev,
>                                           SYSC_MAX_CLOCKS,
> +                                         sizeof(*ddata->clock_roles),
>                                           GFP_KERNEL);
>         if (!ddata->clock_roles)
>                 return -ENOMEM;
> @@ -200,8 +200,8 @@ static int sysc_get_clocks(struct sysc *ddata)
>                 return -EINVAL;
>         }
>
> -       ddata->clocks = devm_kzalloc(ddata->dev,
> -                                    sizeof(*ddata->clocks) * ddata->nr_clocks,
> +       ddata->clocks = devm_kcalloc(ddata->dev,
> +                                    ddata->nr_clocks, sizeof(*ddata->clocks),
>                                      GFP_KERNEL);
>         if (!ddata->clocks)
>                 return -ENOMEM;
> --
> 2.17.0
>
>
> --
> Kees Cook
> Pixel Security



-- 
Kees Cook
Pixel Security