Re: dm: writecache: Use 2-factor allocator arguments

From: Kees Cook
Date: Wed Jun 27 2018 - 17:53:15 EST


On Wed, Jun 27, 2018 at 2:52 PM, Mike Snitzer <snitzer@xxxxxxxxxx> wrote:
> On Wed, Jun 27 2018 at 5:48pm -0400,
> Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
>> On Mon, Jun 18, 2018 at 10:50 AM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>> > This adjusts the allocator calls to use the 2-factor argument style, as
>> > already done treewide for better defense against allocator overflows.
>> > Additionally adjusts style nit to avoid assignments in test expressions.
>> >
>> > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>>
>> Friendly ping -- I'd like to make sure this makes it into 4.18. All
>> other 2-factor allocations have been fixed in the kernel.
>
> Yeap, I'll be sending it to Linus this week. Already staged and ready
> to go, please see:
> https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-4.18&id=50a7d3ba7c9ac5e0b7e03fc7f420180989361dbf

Ah! Thank you very much! :)

-Kees

--
Kees Cook
Pixel Security