Re: [PATCH v2] staging: media: omap4iss: Added SPDX license identifiers

From: Joe Perches
Date: Wed Jun 27 2018 - 09:37:10 EST


On Wed, 2018-06-27 at 11:40 +0300, Dan Carpenter wrote:
> On Tue, Jun 26, 2018 at 11:30:56PM +0200, Daniel Graefe wrote:
> > Changes in v2:
> > - replaced "GPL-2.0-or-later" with "GPL-2.0+"
>
> We should make checkpatch.pl complain when people use wrong tags like
> GPL-2.0-or-later.

I'd rather we use the latest version of the spdx forms.
https://lkml.org/lkml/2018/2/2/883
I think it's better to modify checkpatch when the kernel
uses the latest forms.

There is a separate script that validates the spdx forms.
./scripts/spdxcheck.py

That script, which still needs the patch below, would work
with either style.

https://patchwork.kernel.org/patch/10448573/

$ python ./scripts/spdxcheck.py
include/dt-bindings/reset/amlogic,meson-axg-reset.h: 9:41 Invalid License ID: BSD

or for more verbose output

$ python ./scripts/spdxcheck.py -v
include/dt-bindings/reset/amlogic,meson-axg-reset.h: 9:41 Invalid License ID: BSD

License files: 14
Exception files: 1
License IDs 19
Exception IDs 1

Files checked: 60967
Lines checked: 646729
Files with SPDX: 17393
Files with errors: 1