Re: [PATCH] locking/memory-barriers.txt/kokr: Update Korean translation to fix broken DMA vs. MMIO ordering example

[Paul E. McKenney]

On Tue, Jun 26, 2018 at 09:25:08PM +0900, SeongJae Park wrote:
> Hello Paul,
> 
> On Tue, Jun 26, 2018 at 9:20 PM Paul E. McKenney
> <paulmck@xxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Tue, Jun 26, 2018 at 03:58:27PM +0900, Byungchul Park wrote:
> > > On Tue, Jun 26, 2018 at 02:10:17PM +0900, SeongJae Park wrote:
> > > >
> > > >
> > > > On Tue, 26 Jun 2018, Byungchul Park wrote:
> > > >
> > > > > On Tue, Jun 26, 2018 at 12:21:23PM +0900, sjpark wrote:
> > > > > > Hello Byungchul,
> > > > > >
> > > > > >
> > > > > > On Tue, 26 Jun 2018, Byungchul Park wrote:
> > > > > >
> > > > > > > On Sun, Jun 17, 2018 at 02:16:08PM +0900, SeongJae Park wrote:
> > > > > > > > Translate this commit to Korean:
> > > > > > > >
> > > > > > > >   5846581e3563 ("locking/memory-barriers.txt: Fix broken DMA vs. MMIO ordering example")
> > > > > > >
> > > > > > > Hi SeongJae,
> > > > > > >
> > > > > > > You keep doing good jobs ;)
> > > > > > >
> > > > > > > I believe it would be better if you consider the little things below
> > > > > > > more. What do you think about it, SeongJae?
> > > > > >
> > > > > > Thank you for great comments!
> > > > > >
> > > > > > >
> > > > > > > > Signed-off-by: SeongJae Park <sj38.park@xxxxxxxxx>
> > > > > > > > ---
> > > > > > > >  Documentation/translations/ko_KR/memory-barriers.txt | 15 +++++++--------
> > > > > > > >  1 file changed, 7 insertions(+), 8 deletions(-)
> > > > > > > >
> > > > > > > > diff --git a/Documentation/translations/ko_KR/memory-barriers.txt b/Documentation/translations/ko_KR/memory-barriers.txt
> > > > > > > > index 921739d00f69..ada0a709cce1 100644
> > > > > > > > --- a/Documentation/translations/ko_KR/memory-barriers.txt
> > > > > > > > +++ b/Documentation/translations/ko_KR/memory-barriers.txt
> > > > > > > > @@ -1891,19 +1891,18 @@ Mandatory ëëìëì SMP ììíììë UP ììíììë SMP í
> > > > > > > >             /* ììêì ìì */
> > > > > > > >             desc->status = DEVICE_OWN;
> > > > > > > >
> > > > > > > > -           /* MMIO ë íí ëëììì êìë íê ìì ëëëë ëêí */
> > > > > > > > -           wmb();
> > > > > > > > -
> > > > > > > >             /* ìëìíë ëìíëíì ëëììì êì */
> > > > > > > >             writel(DESC_NOTIFY, doorbell);
> > > > > > > >     }
> > > > > > > >
> > > > > > > >       dma_rmb() ë ëìíëíëëí ëìíë ìììê ìì ëëììê ììêì
> > > > > > > > -     ëëììì ëìíê íê, dma_wmb() ë ëëììê ììì ììêì ëì
> > > > > > > > -     êììì ëê ìì ëìíëíì ëìíê ìììì ëìíëë.  wmb() ë
> > > > > > > > -     ìì ìêìì ìë (cache incoherent) MMIO ììì ìêë ìëíê ìì
> > > > > > > > -     ìì ìêìì ìë ëëë (cache coherent memory) ìêê ìëëììì
> > > > > > > > -     ëìíìê ìí íìíëë.
> > > > > > > > +     ëëëìì êì ëìíê, dma_wmb() ë ëëììê ììì ììêì ëì
> > > > > > > > +     êììì ëê ìì ëìíëíì ëìíê ììì êì ëìíëë.  writel()
> > > > > > >                                                                         ^
> > > > > > >                                                                      ìêë,
> > > > > >
> > > > > > Nice comment.  This will enhance the readability a lot.
> > > > >
> > > > > Could you add this, too? A quite little thing tho.
> > > >
> > > > Oops, I missed that.  Sorry.  Attaching the patch below.
> > > >
> > > >
> > > > Thanks, SeongJae Park
> > >
> > > Thanks a lot, SeongJae.
> > >
> > > Acked-by: Byungchul Park <byungchul.park@xxxxxxx>
> >
> > Thank you both!
> >
> > The patch below is the complete patch, so that I should replace
> > what I have with it, correct?  If not, please help me out here.  ;-)
> 
> Yes, correct! :)

Like this, then?

							Thanx, Paul

------------------------------------------------------------------------

commit 3cb0d7701c4ce6668fb5096c90ec6d5b4bf71638
Author: SeongJae Park <sj38.park@xxxxxxxxx>
Date:   Sun Jun 17 14:16:08 2018 +0900

    locking/memory-barriers.txt/kokr: Update Korean translation to fix broken DMA vs. MMIO ordering example
    
    Translate this commit to Korean:
    
      5846581e3563 ("locking/memory-barriers.txt: Fix broken DMA vs. MMIO ordering example")
    
    Signed-off-by: SeongJae Park <sj38.park@xxxxxxxxx>
    Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
    [ paulmck: Updated based on feedback from Byungchul Park. ]
    Acked-by: Byungchul Park <byungchul.park@xxxxxxx>

diff --git a/Documentation/translations/ko_KR/memory-barriers.txt b/Documentation/translations/ko_KR/memory-barriers.txt
index 921739d00f69..7f01fb1c1084 100644
--- a/Documentation/translations/ko_KR/memory-barriers.txt
+++ b/Documentation/translations/ko_KR/memory-barriers.txt
@@ -1891,22 +1891,22 @@ Mandatory ëëìëì SMP ììíììë UP ììíììë SMP í
 		/* ììêì ìì */
 		desc->status = DEVICE_OWN;
 
-		/* MMIO ë íí ëëììì êìë íê ìì ëëëë ëêí */
-		wmb();
-
 		/* ìëìíë ëìíëíì ëëììì êì */
 		writel(DESC_NOTIFY, doorbell);
 	}
 
      dma_rmb() ë ëìíëíëëí ëìíë ìììê ìì ëëììê ììêì
-     ëëììì ëìíê íê, dma_wmb() ë ëëììê ììì ììêì ëì
-     êììì ëê ìì ëìíëíì ëìíê ìììì ëìíëë.  wmb() ë
-     ìì ìêìì ìë (cache incoherent) MMIO ììì ìêë ìëíê ìì
-     ìì ìêìì ìë ëëë (cache coherent memory) ìêê ìëëììì
-     ëìíìê ìí íìíëë.
-
-     consistent memory ì ëí ììí ëìì ìíì Documentation/DMA-API.txt
-     ëìë ìêíìì.
+     ëëëìì êì ëìíê, dma_wmb() ë ëëììê ììì ììêì ëì
+     êììì ëê ìì ëìíëíì ëìíê ììì êì ëìíëë.  ìêë,
+     writel() ì ììíë ìì ìêìì ìë ëëë (cache coherent memory)
+     ìêê MMIO ìììì ìê ìì ìëëìì êì ëìíëë writel() ìì
+     wmb() ë ìíí íìê ììì ììëìê ëëëë.  writel() ëë ëìì
+     ìëí writel_relaxed() ë ìë ëìì ìêíì ììëë ìêì ììëì
+     ììì íëë.
+
+     writel_relaxed() ì êì ìíë I/O ìêìëì ëí ììí ëìì ìíìë
+     "ìë I/O ëëìì íê" ììì, consistent memory ì ëí ììí ëìì
+     ìíì Documentation/DMA-API.txt ëìë ìêíìì.
 
 
 MMIO ìê ëëì