Re: [PATCH v3 2/4] staging: rtl8723bs: refactor rtw_macaddr_cfg()

[Michael Straube]

On 06/26/18 19:29, Andy Shevchenko wrote:
> On Tue, Jun 26, 2018 at 11:14 AM, Michael Straube
> <straube.linux@xxxxxxxxx> wrote:
> > Using is_broadcast_ether_addr() and is_zero_ether_addr() instead of
> > testing each byte of the mac[] array for 0xff and 0x00 shortens the
> > code and improves readability.
> >
> > If np == NULL, of_get_property() returns NULL, hence the "np" check
> > is not needed.
> >
> > Instead of a fixed default mac address use a random one to reduce the
> > likelihood of mac address collision.
>
> > Thanks to Joe Perches and Dan Carpenter.
>
> I guess you may use Suggested-by tag as well.

Thanks for the hint, I will add it.

Regards
Michael