Re: [PATCH v2 01/11] crypto: xcbc: Remove VLA usage

From: Gustavo A. R. Silva
Date: Mon Jun 25 2018 - 20:55:33 EST




On 06/25/2018 06:06 PM, Kees Cook wrote:
> On Mon, Jun 25, 2018 at 2:23 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
>> warning-3 += -Wswitch-default
>
> This reminds me, though. Should _this_ one get moved to warning-1?
>
> $ git log next-20180625 --no-merges --grep 'mark expected switch
> fall-through' --oneline | wc -l
> 129
>
> Gustavo, have you checked recently how many of these are left? Maybe
> we can move this to default too?
>

I just built today's kernel and we have a total of 704 fall-through warnings with -Wimplicit-fallthrough=2

I think we might be able to do that in this development cycle.

Thanks
--
Gustavo