Re: [PATCH] arm64: dts: hikey: Define wl1835 power capabilities

From: John Stultz
Date: Mon Jun 25 2018 - 17:56:10 EST


On Wed, Jun 13, 2018 at 11:30 AM, John Stultz <john.stultz@xxxxxxxxxx> wrote:
> On Wed, Jun 13, 2018 at 8:13 AM, Ryan Grachek <ryan@xxxxxxxxx> wrote:
>> These properties are required for compatibility with runtime PM.
>> Without these properties, MMC host controller will not be aware
>> of power capabilities. When the wlcore driver attempts to power
>> on the device, it will erroneously fail with -EACCES.
>>
>> Signed-off-by: Ryan Grachek <ryan@xxxxxxxxx>
>
> Fixes: 60f36637bbbd ("wlcore: sdio: allow pm to handle sdio power")
> Tested-by: John Stultz <john.stultz@xxxxxxxxxx>
> Acked-by: John Stultz <john.stultz@xxxxxxxxxx>
>
> Wei Xu: This fixes a functional regression with wifi on the HiKey
> board that was introduced in 4.18-rc with commit 60f36637bbbd
> ("wlcore: sdio: allow pm to handle sdio power").

Wei Xu: Just wanted to follow up to make sure this wasn't missed for
4.18-rc, as I haven't seen it upstream or in -next, and it fixes a
recently introduced regression.

thanks
-john