Re: [PATCH v6 2/3] arm: shmobile: Add the R9A06G032 SMP enabler driver

From: Simon Horman
Date: Mon Jun 25 2018 - 05:43:00 EST


On Mon, Jun 25, 2018 at 11:24:48AM +0200, Geert Uytterhoeven wrote:
> Hi Michel,
>
> On Mon, Jun 25, 2018 at 10:31 AM Michel Pollet
> <michel.pollet@xxxxxxxxxxxxxx> wrote:
> > The Renesas R9A06G032 second CA7 is parked in a ROM pen at boot time, it
> > requires a special enable method to get it started.
> >
> > Signed-off-by: Michel Pollet <michel.pollet@xxxxxxxxxxxxxx>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > ---
> > arch/arm/mach-shmobile/Makefile | 1 +
> > arch/arm/mach-shmobile/smp-r9a06g032.c | 96 ++++++++++++++++++++++++++++++++++
> > 2 files changed, 97 insertions(+)
> > create mode 100644 arch/arm/mach-shmobile/smp-r9a06g032.c
>
> Given this doesn't depend on anything under arch/arm/mach-shmobile/,
> perhaps this should be moved to drivers/soc/renesas/ (and renamed to
> r9a06g032-smp.c for consistency) instead?
>
> Simon: what do you think?

Yes, I think that would be nice.