Re: [PATCH v8 03/26] PM / Domains: Add generic data pointer to genpd_power_state struct

From: Ulf Hansson
Date: Mon Jun 25 2018 - 04:34:46 EST


On 24 June 2018 at 23:09, Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
> On Wed, Jun 20, 2018 at 7:22 PM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
>> From: Lina Iyer <lina.iyer@xxxxxxxxxx>
>>
>> Let's add a data pointer to the genpd_power_state struct, to allow
>> platforms to store per state specific data.
>
> Can you please fold it into a patch actually using this pointer?

Yep, no problem.

Anyway, the change that uses the pointer is "[PATCH v8 21/26] drivers:
firmware: psci: Add support for PM domains using genpd".

Let's see if there is further comments, if not - perhaps you can
squash $subject patch into that change?

>
>> Cc: Lina Iyer <ilina@xxxxxxxxxxxxxx>
>> Signed-off-by: Lina Iyer <lina.iyer@xxxxxxxxxx>
>> Co-developed-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
>> Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
>> ---
>> include/linux/pm_domain.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
>> index 9206a4fef9ac..27fca748344a 100644
>> --- a/include/linux/pm_domain.h
>> +++ b/include/linux/pm_domain.h
>> @@ -44,6 +44,7 @@ struct genpd_power_state {
>> s64 residency_ns;
>> struct fwnode_handle *fwnode;
>> ktime_t idle_time;
>> + void *data;
>> };
>>
>> struct genpd_lock_ops;
>> --
>> 2.17.1
>>

Kind regards
Uffe