Re: [PATCHv2 5/5] arm64: allwinner: a64: Add support for TERES-I laptop

[Arend van Spriel]

On 6/24/2018 6:34 PM, Harald Geyer wrote:
> Icenowy Zheng writes:
> > >å 2018-03-15åç 16:25 +0000ïHarald Geyeråéï
> > > > >+&mmc1 {
> > > > >+	pinctrl-names = "default";
> > > > >+	pinctrl-0 = <&mmc1_pins>;
> > > > >+	vmmc-supply = <&reg_aldo2>;
> > > > >+	vqmmc-supply = <&reg_dldo4>;
> > > > >+	mmc-pwrseq = <&wifi_pwrseq>;
> > > > >+	bus-width = <4>;
> > > > >+	non-removable;
> > > > >+	status = "okay";
> > > > >+
> > > > >+	rtl8723bs: wifi@1 {
> > > > >+		reg = <1>;
> > > > >+		interrupt-parent = <&r_pio>;
> > > > >+		interrupts = <0 3 IRQ_TYPE_LEVEL_LOW>; /* PL3 */
> > > > >+		interrupt-names = "host-wake";
> > > > >+	};

[...]

> > >- This device node has no binding. The "host-wake" interrupt is part of
> > >  Broadcom SDIO Wi-Fi binding, rather than a generic one.
> I think the general mmc and interrupts bindings apply. And the mmc binding
> clearly states that for sub-nodes a compatible string is optional.
>
> However I just realized that the 'interrupt-names' property is not part
> of the general interrupts binding, so I guess at least this property should
> be removed.

Indeed. If the device just used the SDIO interrupt this is not needed. 
The Broadcom device can use either SDIO interrupt or a so-called 
out-of-band host-wake interrupt, which is what the above represents.

Regards,
Arend