Re: [PATCH v3 2/2] iio: adc: Add Spreadtrum SC27XX PMICs ADC support

[Baolin Wang]

Hi Jonathan,

On 22 June 2018 at 22:13, Jonathan Cameron <jonathan.cameron@xxxxxxxxxx> wrote:
> On Thu, 21 Jun 2018 11:14:05 +0800
> Baolin Wang <baolin.wang@xxxxxxxxxx> wrote:
>
>> From: Freeman Liu <freeman.liu@xxxxxxxxxxxxxx>
>>
>> The Spreadtrum SC27XX PMICs ADC controller contains 32 channels,
>> which is used to sample voltages with 12 bits conversion.
>>
>> [Baolin Wang did lots of improvements]
>>
>> Signed-off-by: Freeman Liu <freeman.liu@xxxxxxxxxxxxxx>
>> Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxx>
>
> One trivial missed bit of cleanup inline.  I'll sort that
> when applying if no one else points anything out before I get back to my
> development machine.

Thanks.

>> +
>> +     indio_dev->dev.parent = &pdev->dev;
>> +     indio_dev->name = dev_name(&pdev->dev);
>> +     indio_dev->modes = INDIO_DIRECT_MODE;
>> +     indio_dev->info = &sc27xx_info;
>> +     indio_dev->channels = sc27xx_channels;
>> +     indio_dev->num_channels = ARRAY_SIZE(sc27xx_channels);
>> +     ret = devm_iio_device_register(&pdev->dev, indio_dev);
>> +     if (ret) {
>> +             dev_err(&pdev->dev, "could not register iio (ADC)");
>> +             return ret;
>> +     }
>> +
>> +     platform_set_drvdata(pdev, indio_dev);
>
> Why?  Looks like this is left over from when we had a remove.

Sorry, I missed to remove this redundant code.

-- 
Baolin Wang
Best Regards