Re: [PATCH V7 00/41] Intel(R) Resource Director Technology Cache Pseudo-Locking enabling

From: David Howells
Date: Sat Jun 23 2018 - 19:15:04 EST


Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:

> - Stick the struct into the local header file and not at some random place in
> the source.

Why? It's only used in that one file. There doesn't seem to be any
particular need to share it around.

> - Get rid of the fugly camel case

It's not camel case. It's the name of the option it's encoding. But if it
makes you happy...

> - Move the enablement into a separate function

Okay.

David