Re: [PATCH 5/7] dt-bindings: samsung: Document bindings for Samsung aries boards

From: Krzysztof Kozlowski
Date: Fri Jun 22 2018 - 03:56:49 EST


On 21 June 2018 at 21:09, PaweÅ Chmiel <pawel.mikolaj.chmiel@xxxxxxxxx> wrote:
> Signed-off-by: PaweÅ Chmiel <pawel.mikolaj.chmiel@xxxxxxxxx>
> ---
> Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
> index 14510b215480..edce6602de50 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
> +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
> @@ -2,6 +2,8 @@
>
> Required root node properties:
> - compatible = should be one or more of the following.
> + - "samsung,aries" - for S5PV210-based Samsung Aries board.
> + - "samsung,galaxys" - for S5PV210-based Samsung Galaxy S (i9000) board.

It is not strictly speaking Exynos-based board (as mentioned in the
header at beginning of file) so maybe change it to "Samsung's Exynos
and S5P SoC based boards"?

Best regards,
Krzysztof

> - "samsung,artik5" - for Exynos3250-based Samsung ARTIK5 module.
> - "samsung,artik5-eval" - for Exynos3250-based Samsung ARTIK5 eval board.
> - "samsung,monk" - for Exynos3250-based Samsung Simband board.
> --
> 2.7.4
>