Re: [PATCH 1/4] lib/rhashtable: simplify bucket_table_alloc()

[Davidlohr Bueso]

On Fri, 22 Jun 2018, NeilBrown wrote:

> On Thu, Jun 21 2018, Davidlohr Bueso wrote:
>
> > As of ce91f6ee5 (mm: kvmalloc does not fallback to vmalloc for incompatible gfp flag),
> > we can simplify the caller and trust kvzalloc() to just do the right thing.
>
> Hi,
> it isn't clear to me that this is true.
> With this change we lose __GFP_NOWARN and __GFP_NORETRY.
> I doubt the NORETRY is particularly important as this is if it
> isn't GFP_KERNEL, then it is GFP_ATOMIC which doesn't retry anyway.
> However I cannot see why this patch won't result in warnings when the
> kzalloc() fails.
> What am I missing?

You're right, it might be too agressive to get rid of the GFP_NOWARN for
the callers that do GFP_ATOMIC.

I'll send a new version of this patch along with a better changelog.

Thanks,
Davidlohr

Attachment: signature.asc
Description: Digital signature