Re: [PATCH] ACPI / processor: Finish making acpi_processor_ppc_has_changed() void

From: Rafael J. Wysocki
Date: Thu Jun 21 2018 - 09:16:43 EST


On Tuesday, June 19, 2018 7:02:01 PM CEST Brian Norris wrote:
> Commit bca5f557dcea ("ACPI / processor: Make
> acpi_processor_ppc_has_changed() void") changed one of the declarations
> of acpi_processor_ppc_has_changed() to return void, but the !CPU_FREQ
> version still return int. Let's return void to be consistent.
>
> Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>
> ---
> include/acpi/processor.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/acpi/processor.h b/include/acpi/processor.h
> index 40a916efd7c0..1194a4c78d55 100644
> --- a/include/acpi/processor.h
> +++ b/include/acpi/processor.h
> @@ -309,7 +309,7 @@ static inline void acpi_processor_ppc_exit(void)
> {
> return;
> }
> -static inline int acpi_processor_ppc_has_changed(struct acpi_processor *pr,
> +static inline void acpi_processor_ppc_has_changed(struct acpi_processor *pr,
> int event_flag)
> {
> static unsigned int printout = 1;
> @@ -320,7 +320,6 @@ static inline int acpi_processor_ppc_has_changed(struct acpi_processor *pr,
> "Consider compiling CPUfreq support into your kernel.\n");
> printout = 0;
> }
> - return 0;
> }
> static inline int acpi_processor_get_bios_limit(int cpu, unsigned int *limit)
> {
>

Applied, thanks!