Re: [PATCH 3/3] hwrng: msm - Add support for prng v2

From: Stanimir Varbanov
Date: Thu Jun 21 2018 - 07:27:24 EST


Hi Herbert,

On 06/21/2018 01:15 PM, Herbert Xu wrote:
> On Thu, Jun 21, 2018 at 12:56:34PM +0300, Stanimir Varbanov wrote:
>>
>>> Is this really a pseudo-RNG? If so it needs to be moved over to
>>> the algif_rng interface.
>>
>> Despite the register name (PRNG_ registers prefix) the IP is using FIPS
>> approved algorithm and we can claim that this is true hardware entropy
>> generator.
>
> Whether your RNG is a PRNG or not has nothing to do with the
> algorithm you use. No algorithm can generate entropy out of thin
> air.

OK, I just wanted to say that it is _not_ PRNG and the register names
gives us wrong impression.

--
regards,
Stan