Re: [PATCH v2 14/19] sched/numa: Updation of scan period need not be in lock

From: Mel Gorman
Date: Thu Jun 21 2018 - 05:51:49 EST


On Wed, Jun 20, 2018 at 10:32:55PM +0530, Srikar Dronamraju wrote:
> The metrics for updating scan periods are local or task specific.
> Currently this updation happens under numa_group lock which seems
> unnecessary. Hence move this updation outside the lock.
>
> Running SPECjbb2005 on a 4 node machine and comparing bops/JVM
> JVMS LAST_PATCH WITH_PATCH %CHANGE
> 16 25355.9 25645.4 1.141
> 1 72812 72142 -0.92
>
> Reviewed-by: Rik van Riel <riel@xxxxxxxxxxx>
> Signed-off-by: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>

Acked-by: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx>

--
Mel Gorman
SUSE Labs