Re: [PATCH v2][RESEND] X.509: unpack RSA signatureValue field from BIT STRING

From: James Morris
Date: Wed Jun 20 2018 - 21:44:58 EST


On Wed, 20 Jun 2018, Herbert Xu wrote:

> On Wed, Jun 20, 2018 at 02:24:54PM +0200, Maciej S. Szmigiero wrote:
> >
> > A friendly ping here.
> >
> > @AMD people:
> > Without this patch, in-kernel X.509 certificate verification is broken
> > on AMD CCP RSA implementation.
> >
> > For example, loading wireless regulatory database gives the following
> > errors:
> > > [ 21.310361] cfg80211: Problem loading in-kernel X.509 certificate (-22)
> > > [ 21.351717] cfg80211: loaded regulatory.db is malformed or signature is missing/invalid
> >
> > Kernel modules signature verification probably has similar problem, too.
> >
> > That's why it would be nice if you could ack this patch, please.
>
> David/James, is there an issue with the patch?

Not from my POV.

--
James Morris
<jmorris@xxxxxxxxx>