Re: [PATCH 2/7] x86,tlb: leave lazy TLB mode at page table free time

From: Rik van Riel
Date: Wed Jun 20 2018 - 20:23:58 EST


On Wed, 2018-06-20 at 15:56 -0400, Rik van Riel wrote:
>
> +void tlb_flush_remove_tables(struct mm_struct *mm)
> +{
> + int cpu = get_cpu();
> + /*
> + * XXX: this really only needs to be called for CPUs in lazy
> TLB mode.
> + */
> + if (cpumask_any_but(mm_cpumask(mm), cpu) < nr_cpu_ids)
> + smp_call_function_many(mm_cpumask(mm),
> tlb_flush_remove_tables_local, (void *)mm, 1);
> +}
>

Jens helpfully pointed out I missed a put_cpu().

I have added that in my tree for a v2 of the series.

--
All Rights Reversed.

Attachment: signature.asc
Description: This is a digitally signed message part