Re: [PATCH v10 3/7] x86/time: read_boot_clock64() implementation

[Andy Shevchenko]

On Tue, Jun 19, 2018 at 5:23 PM, Pavel Tatashin
<pasha.tatashin@xxxxxxxxxx> wrote:

>> > > +               *ts = (struct timespec64){0, 0};
>>
>> I dunno if additional variable would be better for readability, like
>>
>> struct timespec64 null_ts = {0,0};
>
> I don't mind adding ts_null, but I think, as-is ok here,

Actually I meant presicely null_ts, and the reason why is that alias
is much easy to parse to get the idea, than to read entire "struct bla
bla bla".

But again, this is my personal point of view.

>
>> ...
>> *ts = null_ts;
>>
>> > > +       else
>> > > +               *ts = ns_to_timespec64(ns_now - ns_boot);
>>
>> But I'm fine as long as Thomas is okay with this code.

> Thank you for the review!

You're welcome!

-- 
With Best Regards,
Andy Shevchenko