Re: [PATCH 5/9] staging: rtl8192u: Use %s and __func__ instead of hardcoded string - Style

[Andy Shevchenko]

On Tue, Jun 19, 2018 at 10:56 PM, John Whitmore <johnfwhitmore@xxxxxxxxx> wrote:
> Changed a number of hard coded function names to use %s and __func__

Oh.

Looking at the code, much better fix would be...

Move IEEE80211_DEBUG() to use netdev_dbg() [dev_dbg() or pr_dbg() as
last resort) and actually drop it completely in favour of the
netdev_dbg() followed by removing __func__ parameter completely from
the messages as DYNAMIC DEBUG will do this if user asks so.

The IEEE80211_DEBUG_DATA() should be just print_hex_dump().

P.S. I would rather NAK this patch because it brings nothing, just a
waste of time for my opinion.

-- 
With Best Regards,
Andy Shevchenko