Re: [PATCH v10 1/7] x86/tsc: remove tsc_disabled flag

From: Thomas Gleixner
Date: Tue Jun 19 2018 - 13:33:17 EST


On Fri, 15 Jun 2018, Pavel Tatashin wrote:

> tsc_disabled is set when notsc is passed as kernel parameter. The reason we
> have notsc is to avoid timing problems on multi-socket systems. We already
> have a mechanism, however, to detect and resolve these issues by invoking
> tsc unstable path. Thus, make notsc to behave the same as tsc=unstable.

notsc also excludes TSC from being used at all, while with your change its
suddenly used in sched_clock().

I'm not opposed to that change but the changelog is completely misleading
as it suggest that this is a change which has no functional impact.

Thanks,

tglx