Re: [PATCH 1/3] locking: WW mutex cleanup

From: Peter Zijlstra
Date: Tue Jun 19 2018 - 07:02:40 EST


On Tue, Jun 19, 2018 at 12:44:52PM +0200, Thomas Hellstrom wrote:
> On 06/19/2018 11:44 AM, Peter Zijlstra wrote:
> > On Tue, Jun 19, 2018 at 10:24:43AM +0200, Thomas Hellstrom wrote:
> > > From: Peter Ziljstra <peterz@xxxxxxxxxxxxx>
> > >
> > > Make the WW mutex code more readable by adding comments, splitting up
> > > functions and pointing out that we're actually using the Wait-Die
> > > algorithm.
> > >
> > > Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> > > Cc: Jonathan Corbet <corbet@xxxxxxx>
> > > Cc: Gustavo Padovan <gustavo@xxxxxxxxxxx>
> > > Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> > > Cc: Sean Paul <seanpaul@xxxxxxxxxxxx>
> > > Cc: David Airlie <airlied@xxxxxxxx>
> > > Cc: Davidlohr Bueso <dave@xxxxxxxxxxxx>
> > > Cc: "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx>
> > > Cc: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
> > > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > > Cc: Kate Stewart <kstewart@xxxxxxxxxxxxxxxxxxx>
> > > Cc: Philippe Ombredanne <pombredanne@xxxxxxxx>
> > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > Cc: linux-doc@xxxxxxxxxxxxxxx
> > > Cc: linux-media@xxxxxxxxxxxxxxx
> > > Cc: linaro-mm-sig@xxxxxxxxxxxxxxxx
> > > Co-authored-by: Thomas Hellstrom <thellstrom@xxxxxxxxxx>
> > > Signed-off-by: Thomas Hellstrom <thellstrom@xxxxxxxxxx>
> > > ---
> > > Documentation/locking/ww-mutex-design.txt | 12 +-
> > > include/linux/ww_mutex.h | 28 ++---
> > > kernel/locking/mutex.c | 202 ++++++++++++++++++------------
> > > 3 files changed, 145 insertions(+), 97 deletions(-)
> > Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
>
> Hi Peter,
>
> Do you want to add a SOB, since you're the main author?

Sure, here goes:

Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>