Re: [PATCH 3/4] ipw2x00: track time using boottime

From: Stanislav Yakovlev
Date: Tue Jun 19 2018 - 06:41:00 EST


On 18/06/2018, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> The ipw2x00 driver family uses get_seconds() to read the current time
> for various purposes. This function is deprecated because of the 32-bit
> time_t overflow, and it can cause unexpected behavior when the time
> changes due to settimeofday() calls or leap second updates.
>
> In many cases, we want to use monotonic time instead, however ipw2x00
> explicitly tracks the time spent in suspend, so this changes the
> driver over to use ktime_get_boottime_seconds(), which is slightly
> slower, but not used in a fastpath here.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/net/wireless/intel/ipw2x00/ipw2100.c | 18 +++++++++---------
> drivers/net/wireless/intel/ipw2x00/ipw2100.h | 12 ++++++------
> drivers/net/wireless/intel/ipw2x00/ipw2200.c | 4 ++--
> drivers/net/wireless/intel/ipw2x00/ipw2200.h | 6 +++---
> 4 files changed, 20 insertions(+), 20 deletions(-)
>

Acked-by: Stanislav Yakovlev <stas.yakovlev@xxxxxxxxx>

Looks fine, thanks!

Stanislav.