Re: [PATCH v3] bitfield: fix *_encode_bits()

From: Andy Shevchenko
Date: Mon Jun 18 2018 - 16:46:13 EST


On Mon, Jun 18, 2018 at 11:42 PM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Mon, 2018-06-18 at 23:40 +0300, Andy Shevchenko wrote:
>
>> The idea is to print what was the input, expected output and actual result.
>> Then you would see what exactly is broken.
>
> Yeah, I guess we could. I did some of that work.
>
>> I dunno how much we may take away from this certain test case, though
>> it would be better for my opinion.
>
> TBH though, I'm not sure I want to do this (right now at least). I don't
> think we gain anything from it, it's so basic ... so to me it's just
> pointless extra code.

I'm not insisting I'm trying to specify rationale behind it.
We may add this later at some point.

--
With Best Regards,
Andy Shevchenko