Re: [PATCH] drm/arm/malidp:- Rectify the width and height passed to rotmem_required()

[Liviu Dudau]

On Fri, Jun 15, 2018 at 01:54:36PM +0100, Ayan Kumar Halder wrote:
> The width and height needs to be swapped
> 
> Signed-off-by: Ayan Kumar halder <ayan.halder@xxxxxxx>
> Reviewed-by: Brian Starkey <brian.starkey@xxxxxxx>
> Reviewed-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@xxxxxxx>
> ---
>  drivers/gpu/drm/arm/malidp_planes.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
> index 377382e..533cdde 100644
> --- a/drivers/gpu/drm/arm/malidp_planes.c
> +++ b/drivers/gpu/drm/arm/malidp_planes.c
> @@ -244,8 +244,8 @@ static int malidp_de_plane_check(struct drm_plane *plane,
>  	if (state->rotation != DRM_MODE_ROTATE_0 || fb->modifier) {
>  		int val;
>  
> -		val = mp->hwdev->hw->rotmem_required(mp->hwdev, state->crtc_h,
> -						     state->crtc_w,
> +		val = mp->hwdev->hw->rotmem_required(mp->hwdev, state->crtc_w,
> +						     state->crtc_h,
>  						     fb->format->format,
>  						     !!(fb->modifier));

Ooops, thanks for catching this! 

Acked-by: Liviu Dudau <liviu.dudau@xxxxxxx>


>  		if (val < 0)
> -- 
> 2.7.4
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    Â\_(ã)_/Â