Re: [PATCH 1/7] MIPS: dts: Add aliases node for lantiq danube serial

[Wu, Songjun]

On 6/14/2018 6:03 PM, Arnd Bergmann wrote:
> On Tue, Jun 12, 2018 at 7:40 AM, Songjun Wu <songjun.wu@xxxxxxxxxxxxxxx> wrote:
> > Previous implementation uses a hard-coded register value to check if
> > the current serial entity is the console entity.
> > Now the lantiq serial driver uses the aliases for the index of the
> > serial port.
> > The lantiq danube serial dts are updated with aliases to support this.
> >
> > Signed-off-by: Songjun Wu <songjun.wu@xxxxxxxxxxxxxxx>
> > ---
> >
> >   arch/mips/boot/dts/lantiq/danube.dtsi | 6 +++++-
> >   1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/mips/boot/dts/lantiq/danube.dtsi b/arch/mips/boot/dts/lantiq/danube.dtsi
> > index 2dd950181f8a..7a9e15da6bd0 100644
> > --- a/arch/mips/boot/dts/lantiq/danube.dtsi
> > +++ b/arch/mips/boot/dts/lantiq/danube.dtsi
> > @@ -4,6 +4,10 @@
> >          #size-cells = <1>;
> >          compatible = "lantiq,xway", "lantiq,danube";
> >
> > +       aliases {
> > +               serial0 = &asc1;
> > +       };
> > +
> You generally want the aliases to be part of the board specific file,
> not every board numbers their serial ports in the same way.
>
>         Arnd
In this chip only asc1 can be used as console, so serial0 is defined in 
chip specific file.