Re: [rcu:rcu/dev 114/116] drivers/iommu/amd_iommu.c:3566:21: sparse: symbol 'stupid_workaround' was not declared. Should it be static?

From: Paul E. McKenney
Date: Sat Jun 09 2018 - 02:16:16 EST


On Sat, Jun 09, 2018 at 04:11:26AM +0800, kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/dev
> head: f20dfe840ba05efdc4071106cffa31cb67cf6bc8
> commit: 814ee31d1f906ad00daccb58944ab16fa279690c [114/116] fixup! EXP iommu: Placeholder for fix in mainline
> reproduce:
> # apt-get install sparse
> git checkout 814ee31d1f906ad00daccb58944ab16fa279690c
> make ARCH=x86_64 allmodconfig
> make C=1 CF=-D__CHECK_ENDIAN__
>
>
> sparse warnings: (new ones prefixed by >>)
>
> drivers/iommu/amd_iommu.c:3539:30: sparse: expression using sizeof(void)
> drivers/iommu/amd_iommu.c:3542:36: sparse: expression using sizeof(void)
> drivers/iommu/amd_iommu.c:3542:36: sparse: expression using sizeof(void)
> >> drivers/iommu/amd_iommu.c:3566:21: sparse: symbol 'stupid_workaround' was not declared. Should it be static?
>
> Please review and possibly fold the followup patch.

This whole thing disappears when I rebase to v4.18-rc1. ;-)

Thanx, Paul