Re: [PATCH] xsk: Fix umem fill/completion queue mmap on 32-bit

[Daniel Borkmann]

On 06/07/2018 06:34 PM, BjÃrn TÃpel wrote:
> Den tors 7 juni 2018 kl 15:37 skrev Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>:
>>
>> With gcc-4.1.2 on 32-bit:
>>
>>     net/xdp/xsk.c:663: warning: integer constant is too large for âlongâ type
>>     net/xdp/xsk.c:665: warning: integer constant is too large for âlongâ type
>>
>> Add the missing "ULL" suffixes to the large XDP_UMEM_PGOFF_*_RING values
>> to fix this.
>>
>>     net/xdp/xsk.c:663: warning: comparison is always false due to limited range of data type
>>     net/xdp/xsk.c:665: warning: comparison is always false due to limited range of data type
>>
>> "unsigned long" is 32-bit on 32-bit systems, hence the offset is
>> truncated, and can never be equal to any of the XDP_UMEM_PGOFF_*_RING
>> values.  Use loff_t (and the required cast) to fix this.
>>
>> Fixes: 423f38329d267969 ("xsk: add umem fill queue support and mmap")
>> Fixes: fe2308328cd2f26e ("xsk: add umem completion queue support and mmap")
>> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
[...]
> 
> Thanks Geert!
> 
> Acked-by: BjÃrn TÃpel <bjorn.topel@xxxxxxxxx>

Applied to bpf, thanks everyone!