Re: [PATCH 3.16 191/410] Input: mms114 - fix license module information

From: Dmitry Torokhov
Date: Thu Jun 07 2018 - 17:41:47 EST


On Thu, Jun 7, 2018 at 7:05 AM, Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote:
> 3.16.57-rc1 review patch. If anyone has any objections, please let me know.

Not a hard objection, but rather a curiosity: for this to be pulled
into stable what user issue does this fix?

>
> ------------------
>
> From: Andi Shyti <andi.shyti@xxxxxxxxxxx>
>
> commit 498e7e7ed1fd72c275a682f0903c4a20cc538658 upstream.
>
> The driver has been released with GNU Public License v2 as stated
> in the header, but the module license information has been tagged
> as "GPL" (GNU Public License v2 or later).
>
> Fix the module license information so that it matches the one in
> the header as "GPL v2".
>
> Fixes: 07b8481d4aff ("Input: add MELFAS mms114 touchscreen driver")
> Reported-by: Marcus Folkesson <marcus.folkesson@xxxxxxxxx>
> Signed-off-by: Andi Shyti <andi.shyti@xxxxxxxxxxx>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> ---
> drivers/input/touchscreen/mms114.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/input/touchscreen/mms114.c
> +++ b/drivers/input/touchscreen/mms114.c
> @@ -592,4 +592,4 @@ module_i2c_driver(mms114_driver);
> /* Module information */
> MODULE_AUTHOR("Joonyoung Shim <jy0922.shim@xxxxxxxxxxx>");
> MODULE_DESCRIPTION("MELFAS mms114 Touchscreen driver");
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("GPL v2");
>



--
Dmitry