Re: [GIT PULL] cgroup changes for v4.18-rc1
From: Tejun Heo
Date: Wed Jun 06 2018 - 11:04:49 EST
Hello, Linus.
On Tue, Jun 05, 2018 at 05:13:55PM -0700, Linus Torvalds wrote:
> On Tue, Jun 5, 2018 at 12:22 PM Tejun Heo <tj@xxxxxxxxxx> wrote:
> >
> > * cgroup uses file modified events to notify certain events. A rate
> > limiting mechanism is added.
>
> This "explanation" didn't really parse for me at all.
>
> I edited the merge message to something that I think is correct and
> made more sense to me.
Heh, yeah, yours reads a lot better. Sorry about that. The
background is that the mechanism was first added to generate
notifications on events like cgroup becoming empty, which is very low
frequency. Since then, we've expanded its usage to cover things like
memory.high breached events which can be a lot higher frequency.
The notification implementation isn't super light weight, so the patch
ratelimits the notifications by capping minimum notification interval
interval to 10ms.
Thanks.
--
tejun