Re: [RFC 2/2] ARM: dts: imx6sl: Convert gpc to new bindings

[Lucas Stach]

Am Dienstag, den 05.06.2018, 20:11 +0300 schrieb Leonard Crestez:
> With old bindings imx_gpc_onecell_data always sets num_domains to 2 so
> the DISPMIX domain can't actually be referenced. The pd is still defined
> and pm core shuts it down as "unused" so display can't work.
> 
> Converting to new gpc bindings by adding pgc nodes, also reference
> referencing the newly-defined &pu_disp domain from &lcdif.
> 
> > Signed-off-by: Leonard Crestez <leonard.crestez@xxxxxxx>
> ---
> Âarch/arm/boot/dts/imx6sl.dtsi | 35 ++++++++++++++++++++++++++++++++---
> Â1 file changed, 32 insertions(+), 3 deletions(-)
> 
> There are erratas regarding dispmix on 6sl so this might be wrong
> 
> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
> index ab6a7e2e7e8f..9982874fa39e 100644
> --- a/arch/arm/boot/dts/imx6sl.dtsi
> +++ b/arch/arm/boot/dts/imx6sl.dtsi
> @@ -694,14 +694,42 @@
> > Â				reg = <0x020dc000 0x4000>;
> > Â				interrupt-controller;
> > Â				#interrupt-cells = <3>;
> > Â				interrupts = <0 89 IRQ_TYPE_LEVEL_HIGH>;
> > Â				interrupt-parent = <&intc>;
> > -				pu-supply = <&reg_pu>;
> > -				clocks = <&clks IMX6SL_CLK_GPU2D_OVG>,
> > -					Â<&clks IMX6SL_CLK_GPU2D_PODF>;
> > +				clocks = <&clks IMX6SL_CLK_IPG>;
> > +				clock-names = "ipg";
> > Â				#power-domain-cells = <1>;

The above power-domain-cells needs to go away when using the new
binding.

Regards,
Lucas

> +				pgc {
> > +					#address-cells = <1>;
> > +					#size-cells = <0>;
> +
> > +					power-domain@0 {
> > +						reg = <0>;
> > +						#power-domain-cells = <0>;
> > +					};
> +
> > > +					pd_pu: power-domain@1 {
> > +						reg = <1>;
> > +						#power-domain-cells = <0>;
> > +						power-supply = <&reg_pu>;
> > +						clocks = <&clks IMX6SL_CLK_GPU2D_OVG>,
> > +						ÂÂÂÂÂÂÂÂÂ<&clks IMX6SL_CLK_GPU2D_PODF>;
> > +					};
> +
> > > +					pd_disp: power-domain@2 {
> > +						reg = <2>;
> > +						#power-domain-cells = <0>;
> > +						clocks = <&clks IMX6SL_CLK_IPG>,
> > +							Â<&clks IMX6SL_CLK_LCDIF_AXI>,
> > +							Â<&clks IMX6SL_CLK_LCDIF_PIX>,
> > +							Â<&clks IMX6SL_CLK_EPDC_AXI>,
> > +							Â<&clks IMX6SL_CLK_EPDC_PIX>,
> > +							Â<&clks IMX6SL_CLK_PXP_AXI>;
> > +					};
> > +				};
> > Â			};
> Â
> > > Â			gpr: iomuxc-gpr@20e0000 {
> > Â				compatible = "fsl,imx6sl-iomuxc-gpr",
> > Â					ÂÂÂÂÂ"fsl,imx6q-iomuxc-gpr", "syscon";
> @@ -752,10 +780,11 @@
> > Â				clocks = <&clks IMX6SL_CLK_LCDIF_PIX>,
> > Â					Â<&clks IMX6SL_CLK_LCDIF_AXI>,
> > Â					Â<&clks IMX6SL_CLK_DUMMY>;
> > Â				clock-names = "pix", "axi", "disp_axi";
> > Â				status = "disabled";
> > +				power-domains = <&pd_disp>;
> > Â			};
> Â
> > > Â			dcp: dcp@20fc000 {
> > Â				compatible = "fsl,imx6sl-dcp", "fsl,imx28-dcp";
> > Â				reg = <0x020fc000 0x4000>;