Re: [PATCH 0/8] serial: 8250: Add 485 emulation to 8250_dw.

From: Matwey V. Kornilov
Date: Mon Jun 04 2018 - 06:34:44 EST


2018-06-04 13:12 GMT+03:00 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>:
> On Fri, 2018-06-01 at 14:40 +0200, Giulio Benetti wrote:
>> Need to handle rs485 with 8250_dw port.
>>
>> Use existing em485 emulation layer for 8250 taking care to fix some
>> bug
>> and taking care especially of RTS_AFTER_SEND case.
>>
>
> I don't see in Cc list author of rs485 code, who might be interested in
> this.
>
> So, added him here.
>

Hi, Andy

Nice to see you there. I will look through the code later.
I always thought that DW has its own hardware rs485 support.

>> Giulio Benetti (8):
>> serial: 8250_dw: add em485 support
>> serial: 8250_dw: allow enable rs485 at boot time
>> serial: 8250: Copy em485 from port to real port.
>> serial: 8250: Handle case port doesn't have TEMT interrupt using
>> em485.
>> serial: 8250_dw: treat rpm suspend with -EBUSY if RS485 ON and
>> RTS_AFTER_SEND
>> serial: 8250: Copy mctrl when register port.
>> serial: 8250: Make em485_rts_after_send() set mctrl according to rts
>> state.
>> serial: core: Mask mctrl with TIOCM_RTS too if rs485 on and
>> RTS_AFTER_SEND set.
>>
>> drivers/tty/serial/8250/8250.h | 2 +-
>> drivers/tty/serial/8250/8250_core.c | 2 ++
>> drivers/tty/serial/8250/8250_dw.c | 41
>> ++++++++++++++++++++++++++++-
>> drivers/tty/serial/8250/8250_omap.c | 2 +-
>> drivers/tty/serial/8250/8250_port.c | 33 ++++++++++++++++-------
>> drivers/tty/serial/serial_core.c | 12 ++++++++-
>> include/linux/serial_8250.h | 1 +
>> 7 files changed, 79 insertions(+), 14 deletions(-)
>>
>
> --
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Intel Finland Oy
>



--
With best regards,
Matwey V. Kornilov.
Sternberg Astronomical Institute, Lomonosov Moscow State University, Russia
119234, Moscow, Universitetsky pr-k 13, +7 (495) 9392382