Re: linux-next-20180601: build error in arch/arm64/kvm/hyp/hyp-entry.S

From: Catalin Marinas
Date: Fri Jun 01 2018 - 17:26:29 EST


Hi Stefan,

On Fri, Jun 01, 2018 at 10:05:07PM +0200, Stefan Wahren wrote:
> i can't build todays linux-next-20180601 and get the following error message:
>
> arch/arm64/kvm/hyp/hyp-entry.S: Assembler messages:
> arch/arm64/kvm/hyp/hyp-entry.S:128: Error: constant expression required at operand 3 -- `bfi x0,x1,#VCPU_WORKAROUND_2_FLAG_SHIFT,#1'
>
> Related commit:
> arm64: KVM: Handle guest's ARCH_WORKAROUND_2 requests
>
> Toolchain: gcc-linaro-7.2.1-2017.11-x86_64_aarch64-linux-gnu
> Kernel config: arm64/defconfig

Thanks for reporting this.

I can hit this as well. It looks like an #ifndef __ASSEMBLY__ in the
wrong place in arch/arm64/include/asm/kvm_asm.h. I can't tell whether it
was caused by a merge conflict resolution or just some unfortunate
interaction between the security fixes going via the arm64 tree and the
other arm64 KVM patches.

I'll have a proper look tomorrow.

--
Catalin