Re: [PATCH v9 01/15] ARM: Add Krait L2 register accessor functions

From: Stephen Boyd
Date: Fri Jun 01 2018 - 13:12:52 EST


Quoting Sricharan R (2018-06-01 06:20:37)
> Hi Stephen,
>
> On 5/31/2018 1:11 PM, Stephen Boyd wrote:
> >
> > Ok. One general comment is that it would be nice if the bindings for all
> > the nodes that are introduced included 'clocks' properties and also
> > maybe 'clock-names' properties for the clocks that are consumed by each
> > node. Right now, we hide those details from DT and rely on the string
> > names to hook the clk tree up for us. That sort of prevents us from
> > moving away from string easily, so I would just throw the clocks into
> > the binding right now and always have them there just in case we want to
> > use the binding to figure out the hierarchy in the future.
> >
>
> ok, understand that mostly. So will try to revamp those patches with
> the 'clocks' property in the binding added, reading them in the driver
> from DT.

Yeah. You don't even have to actually use the clocks property right now
from the drivers. Just add the properties in the binding.