Re: [PATCH] staging: pi433: add rw semaphore fixing concurrency issues

From: Greg Kroah-Hartman
Date: Fri Jun 01 2018 - 12:10:23 EST


On Fri, Jun 01, 2018 at 08:50:37AM -0400, Hugo Lefeuvre wrote:
> Add a rw semaphore fixing potential NULL pointer dereferences in the
> pi433 driver.

Unless you can measure the performance difference, do not use a rw
semaphore, just use a normal mutex please. Odds are it will be faster
in the end and take up less space.

So please test, or if you can't test, just use a mutex.

thanks,

greg k-h