Re: [PATCH V2 02/15] x86/fsgsbase/64: Make ptrace read FS/GS base accurately

From: Andy Lutomirski
Date: Thu May 31 2018 - 16:38:36 EST


On Thu, May 31, 2018 at 1:31 PM <hpa@xxxxxxxxx> wrote:
>
> On May 31, 2018 1:14:59 PM PDT, Andy Lutomirski <luto@xxxxxxxxxx> wrote:
> >On Thu, May 31, 2018 at 10:58 AM Chang S. Bae
> ><chang.seok.bae@xxxxxxxxx> wrote:
> >>
> >> From: Andy Lutomirski <luto@xxxxxxxxxx>
> >>
> >> ptrace can read FS/GS base using the register access API
> >> (PTRACE_PEEKUSER, etc) or PTRACE_ARCH_PRCTL. Make both of these
> >> mechanisms return the actual FS/GS base.
> >>
> >> This will improve debuggability by providing the correct information
> >> to ptracer (GDB and etc).
> >
> >LGTM.
>
> LGTM?

Looks good to me.